fix build vault api version #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhjp
approved these changes
Mar 6, 2024
Zlaticanin
approved these changes
Mar 6, 2024
|
@fairclothjm It looks this broke the build on main. Might be worth taking a look at it. |
|
@benashz We recently added golangci-lint as a build step and that is what is failing. See https://github.com/hashicorp/terraform-provider-vault/actions/runs/8176992328/job/22357626718 I plan to open a PR to fix the outstanding lint errors but it has been low priority recently. Sorry for the noise in the build! |
|
@fairclothjm ok, we may want to disable that check then, since a failing build on main should prevent a release. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.