secrets/ldap: return error on read #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
commented
Feb 26, 2024
| @@ -305,7 +305,7 @@ func TestReadEntity(t *testing.T) { | |||
| expectedRetries: 5, | |||
| wantError: fmt.Errorf(`failed reading %q`, | |||
| entity.JoinEntityID("retry-exhausted-custom-max-412")), | |||
| retryWait: time.Millisecond, | |||
| retryWait: 500 * time.Millisecond, | |||
There was a problem hiding this comment.
This test is flaky so I am bumping this up to see if it will fix it. Not related to this PR at all but I couldn't help myself.
There was a problem hiding this comment.
Nice, things look a lot more robust under stress testing 👍🏼
raymonstah
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Thoughts on having a lint workflow that catches missed error handling? https://golangci-lint.run/usage/linters/#errcheck
vinay-gopalan
approved these changes
Feb 26, 2024
| @@ -305,7 +305,7 @@ func TestReadEntity(t *testing.T) { | |||
| expectedRetries: 5, | |||
| wantError: fmt.Errorf(`failed reading %q`, | |||
| entity.JoinEntityID("retry-exhausted-custom-max-412")), | |||
| retryWait: time.Millisecond, | |||
| retryWait: 500 * time.Millisecond, | |||
There was a problem hiding this comment.
Nice, things look a lot more robust under stress testing 👍🏼
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are swallowing errors which results in incorrect and confusing behavior when Vault returns an error on Read.
Relates #2155
Checklist