Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cert/auth: support OCSP role fields #2056

Merged
merged 5 commits into from
Oct 23, 2023
Merged

cert/auth: support OCSP role fields #2056

merged 5 commits into from
Oct 23, 2023

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Oct 16, 2023 •
edited
Loading

Description

Relates OR Closes #0000

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@fairclothjm fairclothjm added this to the 3.22.0 milestone Oct 16, 2023
@fairclothjm fairclothjm requested a review from a team October 16, 2023 23:23
vinay-gopalan
vinay-gopalan approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Had 1 question around import tests, but should be good to go 👍🏼

vault/resource_cert_auth_backend_role_test.go Show resolved Hide resolved
@fairclothjm fairclothjm merged commit 1c00c77 into main Oct 23, 2023
11 checks passed
@fairclothjm fairclothjm deleted the VAULT-21139/auth/cert/ocsp-role-fields branch October 23, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
documentation size/XL
Projects
None yet
Milestone
3.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fairclothjm @vinay-gopalan