chore: update azure sdk deps #2050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
commented
Oct 13, 2023
|
Followed https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/MIGRATION_GUIDE.md for Error Handling and Pagination |
fairclothjm
force-pushed
the
update-azure-sdk
branch
from
68e5000
to
edd60a5
Compare
fairclothjm
force-pushed
the
update-azure-sdk
branch
from
d81f4d9
to
6483aee
Compare
raymonstah
approved these changes
Oct 16, 2023
| @@ -35,10 +34,6 @@ func TestAccDataSourceAzureAccessCredentials_basic(t *testing.T) { | |||
| resource.TestCheckResourceAttrSet("data.vault_azure_access_credentials.test", "lease_id"), | |||
| ), | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
is this test no longer needed? Seems like it was maybe flaky?
There was a problem hiding this comment.
I don't actually understand this test. I think possibly the source code that it was testing has since been changed. I can't find any error string in TFVP or vault that matches the regex used here.
vinay-gopalan
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1971, closes #1972
Checklist
Output from acceptance testing:
Community Note