Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state migrator for external_member_group_ids in Identity Group #2043

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

vinay-gopalan
Copy link
Contributor

Description

Adds a state migrator for the external_member_group_ids parameter that was added to the Identity Group resource in v3.10.0. Since the parameter is an internal constant with a default value, it should be set to users' TF configs when they upgrade to the new version. Since it was previously not being set for users upon an upgrade, the regression led to the value being null in the TF state. This PR ensures that upon upgrading, if the TF state value is null, set it to the desired default of false

Closes #1690

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestSecretsAuthDisableRemountUpgradeV0'
=== RUN   TestSecretsAuthDisableRemountUpgradeV0
=== RUN   TestSecretsAuthDisableRemountUpgradeV0/basic
--- PASS: TestSecretsAuthDisableRemountUpgradeV0 (0.00s)
    --- PASS: TestSecretsAuthDisableRemountUpgradeV0/basic (0.00s)
PASS

@github-actions github-actions bot added the size/M label Oct 9, 2023
@vinay-gopalan vinay-gopalan requested a review from a team October 9, 2023 19:38
@fairclothjm
Copy link
Contributor

Thanks!

@vinay-gopalan vinay-gopalan added this to the 3.21.0 milestone Oct 9, 2023
@vinay-gopalan vinay-gopalan merged commit 9283df7 into main Oct 9, 2023
11 checks passed
@vinay-gopalan vinay-gopalan deleted the VAULT-12038/identity-group-migrate branch October 9, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 3.10.0: Error: Provider produced inconsistent final plan
2 participants