Update aws_access_credentials documentation link to credential_type

[HorizonNet]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1636

Release note for CHANGELOG:

Update aws_access_credentials documentation link to credential_type

[hashicorp-cla]

All committers have signed the CLA.

[fairclothjm]

Hi @HorizonNet thanks for the submission, but this is not correct. See the documentation for credential_type here: credential_type

[HorizonNet]

@fairclothjm Not sure as the issue originally was that the mentioned credential_type is not referenced somewhere in the data source aws_access_credentials. It is mentioned in the context of the ttl, which is only relevant if the credential_type of the connected vault_aws_secret_backend_role is either assumed_role or federation_token, but not if the credential_type of the vault_aws_secret_backend_role is iam_user. As the credential_type is not mentioned somewhere else on the data source I added a reference to the resource to give a pointer where to look for this one. Or am I missing something else?

[fairclothjm]

@HorizonNet I'm sorry, I completely misread this.

[fairclothjm]

LGTM, just a small suggestion and I am happy to merge this!

[HorizonNet]

@fairclothjm Thanks for taking another look at it. I just updated the PR with your suggestion.

[fairclothjm]

Thanks!