Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PKI Unified CRL parameters #1789

Merged
merged 5 commits into from
Mar 7, 2023

Conversation

davidadeleon
Copy link
Contributor

This PR adds the newly introduced parameters for CRL cross revocation that was introduced in Vault 1.13.0 Enterprise. This solves issues with maintaining or creating new PKI CRL configurations using the provider against Vault 1.13.0.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1788

Release note for CHANGELOG:

update PKI Backend CRL Config resource with new parameters introduced in 1.13.0

Output from testing:

❯ TF_ACC=1 go test -timeout 30s -v -run ^TestPkiSecretBackendCrlConfig$ github.com/hashicorp/terraform-provider-vault/vault
2023/03/07 12:34:35 [INFO] Using Vault token with the following policies: root
=== RUN   TestPkiSecretBackendCrlConfig
=== RUN   TestPkiSecretBackendCrlConfig/vault-1.11-and-below
    resource_pki_secret_backend_crl_config_test.go:88: Vault server version "1.13.0+ent"
    resource_pki_secret_backend_crl_config_test.go:88: Vault version >= "1.12.0"
=== RUN   TestPkiSecretBackendCrlConfig/vault-1.12-and-above
    resource_pki_secret_backend_crl_config_test.go:106: Vault server version "1.13.0+ent"
--- PASS: TestPkiSecretBackendCrlConfig (3.93s)
    --- SKIP: TestPkiSecretBackendCrlConfig/vault-1.11-and-below (0.00s)
    --- PASS: TestPkiSecretBackendCrlConfig/vault-1.12-and-above (3.93s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     4.431s

@github-actions github-actions bot added size/L and removed size/M labels Mar 7, 2023
@vinay-gopalan vinay-gopalan self-requested a review March 7, 2023 18:46
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is looking great! Had 1 comment on one of the tests. We'll also need to update the testing matrix for TFVP in CI so that we're also running against Vault 1.13, but that can be done in a separate PR. Thanks for looking through this!

vault/resource_pki_secret_backend_crl_config_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the docs changes ✅ Thanks once again for taking care of this!

@davidadeleon davidadeleon merged commit 23a1f8b into main Mar 7, 2023
@davidadeleon davidadeleon deleted the davidadeleon/add-pki-unified-crl-options branch March 7, 2023 22:47
@vinay-gopalan vinay-gopalan added this to the 3.14.0 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vault 1.13.0 vault_pki_secret_backend_crl_config error with cross_cluster_revocation
4 participants