Fix KV incorrect metadata path for prefixed mounts #1781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymonstah
approved these changes
Mar 1, 2023
fairclothjm
approved these changes
Mar 2, 2023
|
When can we expect a release with this fix? Without it, risk of ending up with a corrupted state is pretty high! |
|
Apologies for the delay. We had to move some things around in the release to incorporate some features that needed to be added after Vault 1.13 was released. The fix for this issue has been released as part of TFVP v3.14.0. We appreciate your patience, and please let us know if you see this issue again! 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v3.13.0, we aimed to incorporate a fix for the construction of the metadata path for KV V2 secrets (#1722). Unfortunately, this introduced a regression for customers that had prefixed mounts (mounts that were prefixed with a string and contained a
/, for examplecloud-metadata/kvv2-mount). This PR includes a fix that correctly parses mount and secret names from the ID path using regexes.A test has been modified to also test for prefixed mounts. This test fails without the addition of the fixes in this PR.
Fixes #1770 #1780