Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets from the AD, AWS, Azure & Nomad Secrets Engines are sensitive #1726

Merged
merged 1 commit into from
Jan 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions vault/data_source_ad_credentials.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,13 @@ func adAccessCredentialsDataSource() *schema.Resource {
Type: schema.TypeString,
Computed: true,
Description: "Password for the service account.",
Sensitive: true,
},
"last_password": {
Type: schema.TypeString,
Computed: true,
Description: "Last known password for the service account.",
Sensitive: true,
},
"username": {
Type: schema.TypeString,
Expand Down
1 change: 1 addition & 0 deletions vault/data_source_aws_access_credentials.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ func awsAccessCredentialsDataSource() *schema.Resource {
Type: schema.TypeString,
Computed: true,
Description: "AWS security token read from Vault. (Only returned if type is 'sts').",
Sensitive: true,
},

consts.FieldLeaseID: {
Expand Down
1 change: 1 addition & 0 deletions vault/data_source_azure_access_credentials.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ func azureAccessCredentialsDataSource() *schema.Resource {
Type: schema.TypeString,
Computed: true,
Description: "The client secret for credentials to query the Azure APIs.",
Sensitive: true,
},
consts.FieldLeaseID: {
Type: schema.TypeString,
Expand Down
1 change: 1 addition & 0 deletions vault/data_source_nomad_credentials.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ func nomadAccessCredentialsDataSource() *schema.Resource {
Type: schema.TypeString,
Computed: true,
Description: "Used to make requests to Nomad and should be kept private.",
Sensitive: true,
},
},
}
Expand Down