Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ForceNew on the path field of namespaces #1713

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Set ForceNew on the path field of namespaces #1713

merged 4 commits into from
Jan 5, 2023

Conversation

kschoche
Copy link
Contributor

@kschoche kschoche commented Jan 3, 2023 •
edited
Loading

With Terraform Vault provider, the current behaviour is that changing "path" argument of "vault_namespace" resource creates a new namespace but does not destroy the old one, nor update the existing namespace.

@kschoche kschoche self-assigned this Jan 3, 2023
benashz
benashz reviewed Jan 3, 2023
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just had a comment about checking that the old namespace was properly deleted.

vault/resource_namespace_test.go Outdated Show resolved Hide resolved
@benashz benashz added this to the 3.12.0 milestone Jan 4, 2023
@kschoche kschoche changed the title [wip] Set ForceNew on the path field of namespaces Set ForceNew on the path field of namespaces Jan 5, 2023
@kschoche kschoche marked this pull request as ready for review January 5, 2023 17:56
@kschoche kschoche requested a review from benashz January 5, 2023 18:45
benashz
benashz approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kschoche kschoche merged commit cd5e179 into main Jan 5, 2023
@kschoche kschoche deleted the set_forceNew_on_namespace branch January 5, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees

@kschoche kschoche

Labels
namespace-enhancement resource size/XS
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kschoche @benashz