Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR "Add Basic Constraints attribute to vault_pki_secret_backend_intermediate_cert_request" #1661

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Update PR "Add Basic Constraints attribute to vault_pki_secret_backend_intermediate_cert_request" #1661

merged 6 commits into from
Nov 9, 2022

Conversation

robmonte
Copy link
Member

@robmonte robmonte commented Nov 3, 2022

This is a new branch to update the community PR #1160 to resolve merge conflicts and add test coverage.

Output from acceptance testing:

❯ make testacc TESTARGS='-run=^TestPki -count=1'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -run=^TestPki -count=1 -timeout 30m ./...
ok      github.com/hashicorp/terraform-provider-vault/vault     58.566s

Improvement: `vault_pki_secret_backend_intermediate_cert_request` resource to include the `add_basic_constraints` argument. This adds extensions required when signing intermediate CSRs by Microsoft AD CS Root Authorities.

Relates #1160

@robmonte robmonte added this to the 3.11.0 milestone Nov 3, 2022
benashz
benashz reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only a few minor nits+suggestions.

vault/resource_pki_secret_backend_intermediate_cert_request.go Outdated Show resolved Hide resolved
vault/resource_pki_secret_backend_intermediate_cert_request.go Show resolved Hide resolved
vault/resource_pki_secret_backend_intermediate_cert_request_test.go Outdated Show resolved Hide resolved
website/docs/r/pki_secret_backend_intermediate_cert_request.html.md Outdated Show resolved Hide resolved
benashz
benashz approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would just recommend improving the docs a bit, see my related comments.

vault/resource_pki_secret_backend_intermediate_cert_request.go Outdated Show resolved Hide resolved
vault/resource_pki_secret_backend_intermediate_cert_request_test.go Show resolved Hide resolved
benashz
benashz approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor nit then 👍

website/docs/r/pki_secret_backend_intermediate_cert_request.html.md Outdated Show resolved Hide resolved
@robmonte robmonte merged commit 425aa0a into main Nov 9, 2022
@robmonte robmonte deleted the update-pr-add-basic-constraints-pki-intermediate-csr branch November 9, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@robmonte @benashz @tomwerneruk