Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Redis database plugin support #1654

Closed
wants to merge 3 commits into from
Closed

Add Redis database plugin support #1654

wants to merge 3 commits into from

Conversation

blufor
Copy link

@blufor blufor commented Oct 30, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1640

Release note for CHANGELOG:

Added Redis database secrets plugin support

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_redis'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -run=TestAccDatabaseSecretBackendConnection_redis -timeout 30m ./...
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/codegen	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/generated	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/helper	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/consts	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/internal/identity/entity	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/group	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/mfa	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/pki	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/internal/provider	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
ok  	github.com/hashicorp/terraform-provider-vault/testutil	(cached) [no tests to run]
ok  	github.com/hashicorp/terraform-provider-vault/util	(cached) [no tests to run]
panic: Error making API request.

URL: GET https://vault.service.blufor.cloud:8200/v1/auth/token/lookup-self
Code: 403. Errors:

* permission denied

goroutine 1 [running]:
github.com/hashicorp/terraform-provider-vault/vault.initTestProvider.func1()
	/home/blufor/@blu/terraform-provider-vault/vault/provider_test.go:88 +0x19c
sync.(*Once).doSlow(0x0?, 0x0?)
	/usr/lib/go/src/sync/once.go:74 +0xc2
sync.(*Once).Do(...)
	/usr/lib/go/src/sync/once.go:65
github.com/hashicorp/terraform-provider-vault/vault.initTestProvider()
	/home/blufor/@blu/terraform-provider-vault/vault/provider_test.go:70 +0x31
github.com/hashicorp/terraform-provider-vault/vault.init.0()
	/home/blufor/@blu/terraform-provider-vault/vault/provider_test.go:66 +0x17
FAIL	github.com/hashicorp/terraform-provider-vault/vault	0.037s
FAIL
make: *** [Makefile:19: testacc] Error 1
...

Testing failed due to unset test environment and no more time to investigate. Other tests fail too for me. Maybe somebody else can run it? Thx! :)

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 30, 2022

CLA assistant check
All committers have signed the CLA.

@blufor
Copy link
Author

blufor commented Oct 31, 2022

I've tested the code against a nomadized redis deployment with TLS and it works 🎉

@Zlaticanin Zlaticanin self-requested a review October 31, 2022 15:28
@blufor
Copy link
Author

blufor commented Nov 8, 2022

@Zlaticanin Hi there, do you have any (possibly rough) ETA for the review of this?

...or is there anything else I can do to help merging this?

@Zlaticanin
Copy link
Contributor

@Zlaticanin Hi there, do you have any (possibly rough) ETA for the review of this?

...or is there anything else I can do to help merging this?

Hey! Sorry for the late response. Thank you so much for doing this.
So, we have had a PR for Redis TFVP support up for review as well. We took in consideration both PR's, but decided to proceed with ours instead for a couple of reasons. We used a newer style of code for getting the environment variables, moved on from params that are being deprecated, etc..
Thank you so much again for taking the time to do this. We will update you when we get it merged!

@benashz
Copy link
Contributor

benashz commented Nov 9, 2022

Moved to #1659

@benashz benashz closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis database backend is not supported
4 participants