Support configuring vault version handling. #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new provider fields for configuring way that the provider determines the target Vault server's version. - vault_version_override: will set the vault version explicitly, no API requests will be made to retrieve the version - skip_get_vault_version: enable to disable API version requests. If no version can be determined, the lowest supported versioned API semantics will be applied to all resources.
vinay-gopalan
approved these changes
Oct 26, 2022
vault/provider.go
Outdated
| Optional: true, | ||
| Default: false, | ||
| Description: "Skip the dynamic fetching of the Vault server version.", | ||
| ValidateDiagFunc: provider.ValidateDiagSemVer, |
There was a problem hiding this comment.
Should this be validating a semantic version since this is a boolean?
There was a problem hiding this comment.
Nope, good catch! Fixed with 8e28053
marcboudreau
pushed a commit
to marcboudreau/terraform-provider-vault
that referenced
this pull request
Nov 6, 2022
Add two new provider fields for configuring way that the provider determines the target Vault server's version. - vault_version_override: will set the vault version explicitly, no API requests will be made to retrieve the version - skip_get_vault_version: enable to disable API version requests. If no version can be determined, the lowest supported versioned API semantics will be applied to all resources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new provider fields for configuring way that the provider determines the target Vault server's version.
vault_version_override: will set the vault version explicitly, no API requests will be made to retrieve the versionskip_get_vault_version: enable to disable API version requests.If no version can be determined, the lowest supported versioned API semantics will be applied to all resources.
Closes #1643