Use new semantic version checking for Consul secrets backend logic

[robmonte]

Previously we used a workaround to check which Consul policies field was needed by peeking at the Vault response. With semantic version checking we can more simply get which version of Vault is being used, then reconcile that with the field provided by the user.

For backwards compatibility, both policies and consul_policies work regardless of Vault version, 1.11 being where the field name changed in Vault, but the provider handles mapping the data given by the user to the correct parameter name for Vault depending on version.

Release note for CHANGELOG:

NONE

Output from acceptance testing:

❯ make testacc TESTARGS='-run=TestConsulSecretBackend'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test -run=TestConsulSecretBackend -timeout 30m ./...

ok      github.com/hashicorp/terraform-provider-vault/vault     11.553s

 

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

[robmonte]

Note that I have a gofmt commit before my feature commits.

[vinay-gopalan]

LGTM!

[robmonte]

I'm not sure what is causing the CI failures now, is it from the fmt issues?
It was unrelated.

[benashz]

a few minor nits to address then 👍

[benashz]

A few minor suggestions then 👍