fix identityGroupExists #1567
Merged
fix identityGroupExists #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benashz
reviewed
Oct 5, 2022
vault/resource_identity_group.go
Outdated
| } | ||
|
|
||
| log.Printf("[DEBUG] Checking if IdentityGroup %q exists", key) | ||
| resp, err := readIdentityGroup(client, id, true) | ||
| resp, err := client.Logical().Read(path) |
There was a problem hiding this comment.
This change will break the client controlled consistency (CCC) bits. We may need to take a closer look at the issue.
There was a problem hiding this comment.
Since we are no longer supporting schema.Resource.Exists, we can just call d.SetId("") in identityGroupRead() when resp is nil. Then drop identityGroupExists() all together.
There was a problem hiding this comment.
Done! Thanks @benashz
vinay-gopalan
approved these changes
Oct 6, 2022
marcboudreau
pushed a commit
to marcboudreau/terraform-provider-vault
that referenced
this pull request
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #1525
Release note for CHANGELOG: