Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Import for OIDC Scope resource #1548

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Fix Import for OIDC Scope resource #1548

merged 2 commits into from
Jul 25, 2022

Conversation

vinay-gopalan
Copy link
Contributor

The OIDC Scope was previously missing an Import. This PR fixes that.

Fixes #1473

$ make testacc TESTARGS='-v -run TestAccIdentityOIDCScope'
=== RUN   TestAccIdentityOIDCScope
--- PASS: TestAccIdentityOIDCScope (3.31s)
PASS

benashz
benashz approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinay-gopalan vinay-gopalan merged commit 060ccf8 into main Jul 25, 2022
@vinay-gopalan vinay-gopalan deleted the VAULT-6386/fix-scope-import branch July 25, 2022 21:58
@vinay-gopalan vinay-gopalan added this to the 3.8.0 milestone Jul 25, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
@vinay-gopalan
Fix Import for OIDC Scope resource (hashicorp#1548)
ab78067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

vault_identity_oidc_scope import does not work
2 participants
@vinay-gopalan @benashz