Fixing #1387 vault_azure_access_credentials crash #1388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the final change that removes the token from needing access to the azure secrets engine config. It will attempt to query the azure secrets engine for the environment, but if it fails then it will use the value passed into the data source.
|
Thanks for the contribution @mb290. We will be fixing the issue under #1391, since this was work that was already in progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fix for #1387 to allow both subscription_id and tenant_id to be specified. In the event the token doesn't have permission to read the config on the vault backend, it also allows for an environment to be defined in the data source and override the default public cloud option. Values for non-public have been replicated from the Azure Terraform Provider to provide consistency.
Community Note
Relates OR Closes #1387
Release note for CHANGELOG:
Output from acceptance testing: