Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the case where member_identity_ids might be nil #1356

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Handle the case where member_identity_ids might be nil #1356

merged 1 commit into from
Feb 23, 2022

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Feb 21, 2022 •
edited
Loading

During a plan operation the identity_group_member_entity_ids resource
reads the target identity group from Vault. If the identity group
exists, and the resource is configured in non-exclusive mode, the
resource fails to check the result of the type assertion. This results
in an interface conversion panic.

Fix is to check the type assertion before further processing of the
identity group's member_identity_ids field.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1354

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@benashz
Handle the case where member_identity_ids may be nil
449a972 
During a plan operation the identity_group_member_entity_ids resource
reads the target identity group from Vault. If the identity group
exists, and the resource is configured in non-exclusive mode, the
resource fails to check the result of the type assertion. This results
in an interface conversion panic.

Fix is to check the type assertion before further processing of the
identity group's member_identity_ids field.
@benashz benashz changed the title Handle the case where member_identity_ids may be nil Handle the case where member_identity_ids might be nil Feb 21, 2022
@benashz benashz merged commit 2a28888 into main Feb 23, 2022
@benashz benashz deleted the VAULT-5187/handle-nil-response branch February 23, 2022 17:56
@benashz benashz added this to the 3.4.0 milestone Feb 23, 2022
@benashz benashz mentioned this pull request Feb 24, 2022
Closed
@benashz benashz modified the milestones: 3.4.0, 3.3.1 Feb 25, 2022
benashz added a commit that referenced this pull request Feb 25, 2022
@benashz
Update changelog for #1356
00ece92
@benashz benashz mentioned this pull request Feb 25, 2022
Merged
@benashz benashz self-assigned this Feb 25, 2022
benashz added a commit that referenced this pull request Feb 25, 2022
@benashz
Update changelog for #1356 (#1362)
0d34724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees

@benashz benashz

Labels
size/XS
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

Unhandled exception in vault_identity_group_member_entity_ids on plan
2 participants
@benashz @vinay-gopalan