Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAULT-2533] Add Redshift support to Provider #1279

Merged
merged 14 commits into from
Jan 5, 2022
Merged

[VAULT-2533] Add Redshift support to Provider #1279

merged 14 commits into from
Jan 5, 2022

Conversation

vinay-gopalan
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

`resource/database_secret_backend_connection`: Add support for configuring Redshift databases

Output from acceptance testing:

$ make testacc TESTARGS='-v -run TestAccDatabaseSecretBackendConnection_redshift''
RUN   TestAccDatabaseSecretBackendConnection_redshift
--- PASS: TestAccDatabaseSecretBackendConnection_redshift (2.37s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault
...

@github-actions github-actions bot added the size/M label Jan 3, 2022
@vinay-gopalan vinay-gopalan added this to the 3.2.0 milestone Jan 3, 2022
benashz
benashz approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@benashz benashz self-requested a review January 5, 2022 21:58
benashz
benashz approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time for sure 👍

@vinay-gopalan vinay-gopalan merged commit 4cce352 into main Jan 5, 2022
@vinay-gopalan vinay-gopalan deleted the feature/redshift-db-support branch January 5, 2022 22:42
@benashz benashz mentioned this pull request May 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

Assignees
No one assigned
Labels
documentation feature-parity size/M
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vinay-gopalan @benashz