Prevent invalid policy_arns from being created. #1229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the update to TF SDKv2 calling schema.ResourceData.Get() on a
TypeSet now returns nil. The previous code was testing for empty string,
which resulted in the
policy_arns
being set to [""] in Vault when nopolicy_arns
were specified in the TF code.The offending conditional was referencing the vestigial schema key named
policy_arn
, which has now been removed.Additional fixes:
policy
error, since the JSON parse errors are treated as non fatal
Community Note
Closes #1226 #925
Output from acceptance testing: