Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provider tests and fix S3 secret issue (#1173) #1196

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Add provider tests and fix S3 secret issue (#1173) #1196

merged 1 commit into from
Oct 18, 2021

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Oct 18, 2021

Port #1173 to main.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #1173

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@benashz benashz requested a review from tvoran October 18, 2021 19:05
@benashz benashz merged commit 1e7b183 into main Oct 18, 2021
@benashz benashz deleted the port-1173-to-main branch October 18, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran approved these changes

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benashz @tvoran @vinay-gopalan @mbillow