Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowed_serial_numbers support #1119

Closed

Conversation

axolotlgeoff
Copy link
Contributor

This adds support for the allowed_serial_numbers setting in the vault_pki_secret_backend_role resource.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

`resource/vault_pki_secret_backend_role`: Add `allowed_serial_numbers` option

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestPkiSecretBackendRole'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v -run=TestPkiSecretBackendRole -timeout 120m
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/codegen	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/generated	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/decode	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/datasources/transform/encode	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/alphabet	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/role	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/template	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/generated/resources/transform/transformation	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/util	(cached) [no tests to run]
=== RUN   TestPkiSecretBackendRole_basic
--- PASS: TestPkiSecretBackendRole_basic (0.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-vault/vault	0.483s

@hashicorp-cla
Copy link

hashicorp-cla commented Jul 27, 2021

CLA assistant check
All committers have signed the CLA.

@benashz benashz added this to the 3.4.0 milestone Feb 11, 2022
@benashz benashz self-requested a review February 11, 2022 14:01
@benashz benashz modified the milestones: 3.4.0, 3.5.0 Mar 15, 2022
@benashz benashz modified the milestones: 3.5.0, 3.6.0 Apr 20, 2022
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR and apologies for the delay! The PR is looking great!

vault/resource_pki_secret_backend_role.go Outdated Show resolved Hide resolved
vault/resource_pki_secret_backend_role.go Outdated Show resolved Hide resolved
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after merging commits, thanks for your contribution to HashiCorp!

vault/resource_pki_secret_backend_role.go Outdated Show resolved Hide resolved
vault/resource_pki_secret_backend_role.go Outdated Show resolved Hide resolved
@vinay-gopalan
Copy link
Contributor

Since CI tests are failing due to this branch being on an older version of the codebase, the work has been taken over in a new PR forked from this branch. Closing this PR with #1441

Thanks once again for your contribution to HashiCorp!

vinay-gopalan added a commit that referenced this pull request May 9, 2022
marcboudreau pushed a commit to marcboudreau/terraform-provider-vault that referenced this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants