-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource for GCP Static Account #1094
Conversation
…vider-vault into gcp-static
Hey, @austingebauer, not sure if you're the right person for this PR. This is the final bit in the "GCP static account saga". |
Thanks for doing this, @lawliet89! I will have a look at this along with others who are more familiar with the provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments and questions to get started. Thanks again, @lawliet89!
Co-authored-by: Austin Gebauer <[email protected]>
@lawliet89 - This is looking good. I'm going to have someone more familiar with the provider take a quick look before I merge it. Thanks again! |
Co-authored-by: Ben Ash <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Refactor some GCP functions out to a separate file * Add GCP Static account resource * Rename Binding type * Add tests * Update * Update prefix Ref hashicorp/vault-plugin-secrets-gcp@8fba665 * Add docs * Apply suggestions from code review Co-authored-by: Austin Gebauer <[email protected]> * Rename function * Update vault/resource_gcp_secret_static_account.go Co-authored-by: Ben Ash <[email protected]> * Add some comments Co-authored-by: Austin Gebauer <[email protected]> Co-authored-by: Ben Ash <[email protected]>
Community Note
Implemented in hashicorp/vault-plugin-secrets-gcp#107, merged to Vault in hashicorp/vault#12023 and documented in hashicorp/vault#12027
Release note for CHANGELOG:
Output from acceptance testing:
Test was done by installing a custom build of the plugin into a Vault Dev server.