Disable KMIP role test, remove vault-1.9 job

hashicorp · May 18, 2022 · 2dd1462 · 2dd1462
1 parent f57fb51
commit 2dd1462
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -6,14 +6,16 @@ jobs:
   container-job:
     runs-on: ubuntu-latest
     strategy:
-      fail-fast: true
+      fail-fast: false
       matrix:
-        image: ["hashicorp/vault-enterprise:1.10-ent", "hashicorp/vault-enterprise:1.9-ent"]
+        # TODO: enable 1.9 job once the provider is Vault version aware
+        #image: ["vault-enterprise:1.9-ent", "vault-enterprise:1.10-ent"]
+        image: ["vault-enterprise:1.10-ent"]
     container:
       image: docker.mirror.hashicorp.services/golang:1.17.10
     services:
       vault:
-        image: ${{ matrix.image }}
+        image: hashicorp/${{ matrix.image }}
         env:
           VAULT_DEV_ROOT_TOKEN_ID: root
           VAULT_LICENSE: ${{ secrets.VAULT_LICENSE }}

diff --git a/vault/resource_kmip_secret_role_test.go b/vault/resource_kmip_secret_role_test.go
@@ -74,6 +74,7 @@ func TestAccKMIPSecretRole_basic(t *testing.T) {
 }
 
 func TestAccKMIPSecretRole_remount(t *testing.T) {
+	t.Skip("Skip until remount, and bind addr issues are resolved")
 	path := acctest.RandomWithPrefix("tf-test-kmip")
 	remountPath := acctest.RandomWithPrefix("tf-test-kmip-remount")
 	resourceName := "vault_kmip_secret_role.test"