-
Notifications
You must be signed in to change notification settings - Fork 115
Port TLS Provider to terraform-plugin-framework
#215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bendbennett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
bendbennett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good. I'm definitely going to re-use some of your ideas.
ad491e9 to
615f8f6
Compare
615f8f6 to
1e4cfe5
Compare
terraform-plugin-frameworkterraform-plugin-framework
terraform-plugin-frameworkterraform-plugin-framework
bendbennett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks great.
internal/provider/attribute_plan_modification/attribute_plan_modifiers.go
Outdated
Show resolved
Hide resolved
This is what terraform-plugin-framework uses.
016e408 to
e37b8d7
Compare
terraform-plugin-frameworkterraform-plugin-framework
… a `Default: true`.
This will be a "release candidate" release, that will not be picked by automatic upgrades.
bflad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks really good, nice work migrating this non-trivial provider! 🚀
…g the intermediate planning state
|
If we upgrade to the latest tls provider (4.0.4), and we bump in to issue #87, will applying cause all of our certificates to be replaced or will the update be a no-op? I'm using a fork of the tls provider to workaround #87 but I'm looking in to moving back to the main branch, however I can't have the plan replace the certificates spuriously. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes #196
Closes #87
Closes #185
Closes #174
This is a full port of the
terraform-tls-providerto the new, and almostv1.x,terraform-plugin-framework.As it is a breaking change (version of TF
<0.15become not compatible with this provider), I'm taking this opportunity to include other breaking changes that had been waiting for a while. Some of which (like #87), are long overdue and made necessary by the new framework, not supporting certain things (StateFuncinSchemadefinition).The
CHANGELOGcontains all the details.