Skip to content

Conversation

@DanielRis
Copy link

dataSourceTlsCertificateRead now use an http client instead of tls to allow proxy usage inside Corporate environments.

Fixes #96

@ghost ghost added size/XS labels Apr 29, 2021
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 29, 2021

CLA assistant check
All committers have signed the CLA.

@donovanmuller
Copy link

@DanielRis any chance you could sign the CLA? Perhaps it could spark some activity/review on your PR?

@DanielRis
Copy link
Author

@DanielRis any chance you could sign the CLA? Perhaps it could spark some activity/review on your PR?

I thought I did that already, but I now did that again.

@vikas027
Copy link

Hey @donovanmuller ,
Any news of this being approved and a new release ;)

@donovanmuller
Copy link

@vikas027 I'm not a maintainer, so unfortunately I can't. I am, like you, waiting and hoping for any movement on this PR/issue 😃

@hajowieland
Copy link

bump. When can we expect this PR to get merged?

@DanielRis
Copy link
Author

DanielRis commented Feb 23, 2022

@detro @bflad would you please be so kind to review this MR and maybe merge it? I would really like start using this inside our corp network with in combination with the new EKS module.

@kongdewen
Copy link

bump! with module like terraform-aws-eks: https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/main.tf#L149-L153 adopts this module, this diff will help a lot of users utilize this module.

hanblee added a commit to hanblee/terraform-provider-tls that referenced this pull request Mar 18, 2022
 hashicorp#113 (dataSourceTlsCertificateRead now uses http client hashicorp#113)
@detro detro self-assigned this Mar 22, 2022
@detro
Copy link
Contributor

detro commented Mar 31, 2022

Thank you for this initial implementation.

While this was a great start, the feature needed to be better integrated on the provider level, and designed to support current and future usages.

I have just opened #179 that should cover the needs of #96, so I'll close this one.

@detro detro closed this Mar 31, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] Support HTTP proxy for tls_certificate data source

7 participants