Adding ForceNew and removing Computed from Seed to enable resource up…

…date

Also adding tests to update existing seed, go from seedless to seeded, and seeded to seedless.

random/resource_integer.go

@@ -40,7 +40,7 @@ func resourceInteger() *schema.Resource {
 			"seed": {
 				Type:     schema.TypeString,
 				Optional: true,
-				Computed: true,
+				ForceNew: true,
 			},
 
 			"result": {

random/resource_integer_test.go

@@ -30,6 +30,72 @@ func TestAccResourceIntegerBasic(t *testing.T) {
 	})
 }
 
+func TestAccResourceIntegerUpdate(t *testing.T) {
+	t.Parallel()
+	resource.UnitTest(t, resource.TestCase{
+		PreCheck:  func() { testAccPreCheck(t) },
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: testRandomIntegerBasic,
+				Check: resource.ComposeTestCheckFunc(
+					testAccResourceIntegerBasic("random_integer.integer_1"),
+				),
+			},
+			{
+				Config: testRandomIntegerUpdate,
+				Check: resource.ComposeTestCheckFunc(
+					testAccResourceIntegerUpdate("random_integer.integer_1"),
+				),
+			},
+		},
+	})
+}
+
+func TestAccResourceIntegerSeedless_to_seeded(t *testing.T) {
+	t.Parallel()
+	resource.UnitTest(t, resource.TestCase{
+		PreCheck:  func() { testAccPreCheck(t) },
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: testRandomIntegerSeedless,
+				Check: resource.ComposeTestCheckFunc(
+					testAccResourceIntegerSeedless("random_integer.integer_1"),
+				),
+			},
+			{
+				Config: testRandomIntegerUpdate,
+				Check: resource.ComposeTestCheckFunc(
+					testAccResourceIntegerUpdate("random_integer.integer_1"),
+				),
+			},
+		},
+	})
+}
+
+func TestAccResourceIntegerSeeded_to_seedless(t *testing.T) {
+	t.Parallel()
+	resource.UnitTest(t, resource.TestCase{
+		PreCheck:  func() { testAccPreCheck(t) },
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: testRandomIntegerBasic,
+				Check: resource.ComposeTestCheckFunc(
+					testAccResourceIntegerBasic("random_integer.integer_1"),
+				),
+			},
+			{
+				Config: testRandomIntegerSeedless,
+				Check: resource.ComposeTestCheckFunc(
+					testAccResourceIntegerSeedless("random_integer.integer_1"),
+				),
+			},
+		},
+	})
+}
+
 func testAccResourceIntegerBasic(id string) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		rs, ok := s.RootModule().Resources[id]
@@ -53,12 +119,71 @@ func testAccResourceIntegerBasic(id string) resource.TestCheckFunc {
 	}
 }
 
+func testAccResourceIntegerUpdate(id string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		rs, _ := s.RootModule().Resources[id]
+		// if !ok {
+		// 	return fmt.Errorf("Not found: %s", id)
+		// }
+		result := rs.Primary.Attributes["result"]
+
+		if rs.Primary.ID == "" {
+			return fmt.Errorf("No ID is set")
+		}
+
+		if result == "" {
+			return fmt.Errorf("Result not found")
+		}
+
+		if result != "2" {
+			return fmt.Errorf("Invalid result %s. Seed does not result in correct value", result)
+		}
+		return nil
+	}
+}
+
+// testAccResourceIntegerSeedless only checks that some result was returned, and does not validate the value.
+func testAccResourceIntegerSeedless(id string) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		rs, ok := s.RootModule().Resources[id]
+		if !ok {
+			return fmt.Errorf("Not found: %s", id)
+		}
+		result := rs.Primary.Attributes["result"]
+
+		if rs.Primary.ID == "" {
+			return fmt.Errorf("No ID is set")
+		}
+
+		if result == "" {
+			return fmt.Errorf("Result not found")
+		}
+
+		return nil
+	}
+}
+
 const (
 	testRandomIntegerBasic = `
 resource "random_integer" "integer_1" {
    min  = 1
    max  = 3
    seed = "12345"
 }
+`
+
+	testRandomIntegerUpdate = `
+resource "random_integer" "integer_1" {
+   min  = 1
+   max  = 3
+   seed = "123456"
+}
+`
+
+	testRandomIntegerSeedless = `
+resource "random_integer" "integer_1" {
+   min  = 1
+   max  = 3
+}
 `
 )