Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/pod - add plan time validations #1275

Merged
merged 3 commits into from
May 19, 2021

Conversation

DrFaust92
Copy link
Contributor

@DrFaust92 DrFaust92 commented May 18, 2021

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccKubernetesPod_'
--- PASS: TestAccKubernetesPod_with_node_affinity_with_required_during_scheduling_ignored_during_execution (21.42s)
--- PASS: TestAccKubernetesPod_with_node_affinity_with_preferred_during_scheduling_ignored_during_execution (17.44s)
--- PASS: TestAccKubernetesPod_with_pod_affinity_with_required_during_scheduling_ignored_during_execution (29.15s)
--- PASS: TestAccKubernetesPod_with_pod_affinity_with_preferred_during_scheduling_ignored_during_execution (28.43s)
--- PASS: TestAccKubernetesPod_with_pod_anti_affinity_with_required_during_scheduling_ignored_during_execution (28.52s)
--- PASS: TestAccKubernetesPod_with_pod_anti_affinity_with_preferred_during_scheduling_ignored_during_execution (12.75s)
--- PASS: TestAccKubernetesPod_minimal (22.55s)
--- PASS: TestAccKubernetesPod_basic (27.67s)
--- PASS: TestAccKubernetesPod_initContainer_updateForcesNew (130.37s)
--- PASS: TestAccKubernetesPod_updateArgsForceNew (116.10s)
--- PASS: TestAccKubernetesPod_updateEnvForceNew (51.89s)
--- PASS: TestAccKubernetesPod_with_pod_security_context (13.92s)
--- PASS: TestAccKubernetesPod_with_pod_security_context_run_as_group (25.63s)
--- PASS: TestAccKubernetesPod_with_container_liveness_probe_using_exec (47.54s)
--- PASS: TestAccKubernetesPod_with_container_liveness_probe_using_http_get (18.18s)
--- PASS: TestAccKubernetesPod_with_container_liveness_probe_using_tcp (17.99s)
--- PASS: TestAccKubernetesPod_with_container_lifecycle (10.79s)
--- PASS: TestAccKubernetesPod_with_container_security_context (22.75s)
--- PASS: TestAccKubernetesPod_with_volume_mount (22.93s)
--- PASS: TestAccKubernetesPod_with_cfg_map_volume_mount (23.17s)
--- PASS: TestAccKubernetesPod_with_projected_volume (53.47s)
--- PASS: TestAccKubernetesPod_with_resource_requirements (10.24s)
--- PASS: TestAccKubernetesPod_with_empty_dir_volume (20.65s)
--- PASS: TestAccKubernetesPod_with_empty_dir_volume_with_sizeLimit (22.30s)
--- PASS: TestAccKubernetesPod_with_secret_vol_items (14.45s)
--- PASS: TestAccKubernetesPod_config_with_automount_service_account_token (23.21s)
--- PASS: TestAccKubernetesPod_config_container_working_dir (30.20s)
--- PASS: TestAccKubernetesPod_config_container_startup_probe (10.68s)
--- PASS: TestAccKubernetesPod_termination_message_policy_default (10.66s)
--- PASS: TestAccKubernetesPod_termination_message_policy_override_as_file (14.70s)
--- PASS: TestAccKubernetesPod_termination_message_policy_override_as_fallback_to_logs_on_err (22.71s)
--- PASS: TestAccKubernetesPod_enableServiceLinks (22.82s)
--- PASS: TestAccKubernetesPod_bug961EmptyBlocks (0.70s)
--- PASS: TestAccKubernetesPod_readinessGate (23.28s)
--- PASS: TestAccKubernetesPod_topologySpreadConstraint (22.57s)
--- PASS: TestAccKubernetesPod_filterAnnotations (22.65s)
--- PASS: TestAccKubernetesPod_regression (160.07s)

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added the size/M label May 18, 2021
@jrhouston jrhouston self-assigned this May 18, 2021
@ghost ghost added size/XL and removed size/M labels May 19, 2021
@alexsomesan alexsomesan merged commit 062cf7e into hashicorp:main May 19, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
@DrFaust92 DrFaust92 deleted the r/pod_validations branch June 19, 2021 09:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants