Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all go dependencies #1240

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

dak1n1
Copy link
Contributor

@dak1n1 dak1n1 commented Apr 15, 2021

Description

Update all dependencies, and remove tools.go.

Previously, we were using tools.go to keep go.mod from changing during package installations. That is no longer needed.

go install now accepts arguments with version suffixes (for example, go install example.com/[email protected]). This causes go install to build and install packages in module-aware mode, ignoring the go.mod file in the current directory or any parent directory, if there is one. This is useful for installing executables without affecting the dependencies of the main module.

https://tip.golang.org/doc/go1.16#go-command

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

...

References

#1238

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added size/XXL labels Apr 15, 2021
@dak1n1 dak1n1 requested a review from a team April 15, 2021 19:34
Update all dependencies. Also, remove tools.go, which was used in the makefile for package installation.
This is no longer needed as of Go version 1.16. https://tip.golang.org/doc/go1.16#go-command
Copy link
Member

@alexsomesan alexsomesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexsomesan alexsomesan merged commit d6c3170 into hashicorp:main May 4, 2021
@github-actions
Copy link

github-actions bot commented Jun 4, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants