Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validateTypeStringNullableIntOrPercent should tolerate 100% value #1107

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

dee-kryvenko
Copy link
Contributor

@dee-kryvenko dee-kryvenko commented Jan 4, 2021

Description

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note

Release note for CHANGELOG:

kubernetes_pod_disruption_budget: `100%` now is a valid value

References

Fixes #1106

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@ghost ghost added size/XS labels Jan 4, 2021
@jrhouston
Copy link
Collaborator

I just realized there's no unit test for this validator function – would you be willing to add one for the the case you've added @dee-kryvenko ?

Base automatically changed from master to main March 23, 2021 15:53
@ghost ghost added size/S and removed size/XS labels Mar 31, 2021
@jrhouston jrhouston merged commit ddc3070 into hashicorp:main Mar 31, 2021
@ghost
Copy link

ghost commented May 1, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2021
@dee-kryvenko dee-kryvenko deleted the patch-1 branch June 21, 2021 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDB: Error: spec.0.min_available: '100%' is not between 0% and 100%
2 participants