fix linter in tpg

[ScottSuarez]

Helps with #9145

ref:
golangci/golangci-lint#2017

[melinath]

I still get the following errors locally that aren't in CI:

google/resource_container_cluster_test.go:2366:6: func `testAccContainerCluster_updateVersion` is unused (unused)
google/resource_container_node_pool_test.go:1284:6: func `testAccContainerNodePool_version` is unused (unused)
google/resource_container_node_pool_test.go:1308:6: func `testAccContainerNodePool_updateVersion` is unused (unused)
google/resource_container_cluster_test.go:2644:6: func `testAccContainerCluster_withNodePoolLowerVersion` is unused (unused)
google/resource_container_cluster_test.go:2351:6: func `testAccContainerCluster_withLowerVersion` is unused (unused)
google/resource_container_cluster_test.go:2665:6: func `testAccContainerCluster_withNodePoolUpdateVersion` is unused (unused)

[ScottSuarez]

I still get the following errors locally that aren't in CI:

google/resource_container_cluster_test.go:2366:6: func `testAccContainerCluster_updateVersion` is unused (unused)

google/resource_container_node_pool_test.go:1284:6: func `testAccContainerNodePool_version` is unused (unused)

google/resource_container_node_pool_test.go:1308:6: func `testAccContainerNodePool_updateVersion` is unused (unused)

google/resource_container_cluster_test.go:2644:6: func `testAccContainerCluster_withNodePoolLowerVersion` is unused (unused)

google/resource_container_cluster_test.go:2351:6: func `testAccContainerCluster_withLowerVersion` is unused (unused)

google/resource_container_cluster_test.go:2665:6: func `testAccContainerCluster_withNodePoolUpdateVersion` is unused (unused)

Yeah this is due to a newer version of the linter. This error is legitimate. The tests that use these functions use a t.skip which is considered an early return. We will need to fix those tests to be conditional skips

[melinath]

@ScottSuarez why do those errors not show up in CI? Is it on an old version of the linter?

[melinath]

LGTM - definitely an improvement over the current state. I think it doesn't quite close the ticket as-is, though, since there are still errors that are showing up locally but not in CI.

[melinath]

LGTM - definitely an improvement over the current state. I think it doesn't quite close the ticket as-is, though, since there are still errors that are showing up locally but not in CI.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.