Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make location required on google_cloudfunctions2_function #15830

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/8928.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:breaking-change
cloudfunction2: made `location` required on `google_cloudfunctions2_function`
```
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ func ResourceCloudfunctions2function() *schema.Resource {
),

Schema: map[string]*schema.Schema{
"location": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
Description: `The location of this cloud function.`,
},
"name": {
Type: schema.TypeString,
Required: true,
Expand Down Expand Up @@ -273,12 +279,6 @@ It must match the pattern projects/{project}/locations/{location}/keyRings/{key_
Description: `A set of key/value label pairs associated with this Cloud Function.`,
Elem: &schema.Schema{Type: schema.TypeString},
},
"location": {
Type: schema.TypeString,
Optional: true,
ForceNew: true,
Description: `The location of this cloud function.`,
},
"service_config": {
Type: schema.TypeList,
Optional: true,
Expand Down
8 changes: 4 additions & 4 deletions website/docs/r/cloudfunctions2_function.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,10 @@ The following arguments are supported:
A user-defined name of the function. Function names must
be unique globally and match pattern `projects/*/locations/*/functions/*`.

* `location` -
(Required)
The location of this cloud function.


- - -

Expand Down Expand Up @@ -803,10 +807,6 @@ The following arguments are supported:
Resource name of a KMS crypto key (managed by the user) used to encrypt/decrypt function resources.
It must match the pattern projects/{project}/locations/{location}/keyRings/{key_ring}/cryptoKeys/{crypto_key}.

* `location` -
(Optional)
The location of this cloud function.

* `project` - (Optional) The ID of the project in which the resource belongs.
If it is not provided, the provider project is used.

Expand Down