Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Cloud Functions 2nd generation creation failure state inconsistency #15418

Conversation

modular-magician
Copy link
Collaborator

Currently whenever a Cloud Function gen2 creation fails, the state is kept empty, which causes subsequent TF apply runs to fail with "the function already exists". This change addresses this by adding the taint_resource_on_failed_create MMv1 parameter to the resource. Fixes #13535.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloudfunctions2: fixed creation failure TF state inconsistency in `google_cloudfunctions2_function`

Derived from GoogleCloudPlatform/magic-modules#8545

@modular-magician modular-magician merged commit 689dff2 into hashicorp:main Aug 7, 2023
4 checks passed
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_cloudfunctions2_function created in GCP but not stored in tfstate if in failed state
1 participant