-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add App Engine Application support #1503
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
765d9af
Beginnings of App Engine app support.
paddycarver 02a4259
Add basic test and fix bugs.
paddycarver f78de6b
Drop the resources we can't support.
paddycarver e74ab9d
Vendor.
paddycarver 98b6323
Fix suggestions from @ndmckinley.
paddycarver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
package google | ||
|
||
import ( | ||
"fmt" | ||
"log" | ||
"regexp" | ||
"strconv" | ||
"time" | ||
|
||
"github.com/hashicorp/terraform/helper/resource" | ||
|
||
"google.golang.org/api/appengine/v1" | ||
) | ||
|
||
var ( | ||
appEngineOperationIdRE = regexp.MustCompile(fmt.Sprintf("apps/%s/operations/(.*)", ProjectRegex)) | ||
) | ||
|
||
type AppEngineOperationWaiter struct { | ||
Service *appengine.APIService | ||
Op *appengine.Operation | ||
AppId string | ||
} | ||
|
||
func (w *AppEngineOperationWaiter) RefreshFunc() resource.StateRefreshFunc { | ||
return func() (interface{}, string, error) { | ||
matches := appEngineOperationIdRE.FindStringSubmatch(w.Op.Name) | ||
if len(matches) != 2 { | ||
return nil, "", fmt.Errorf("Expected %d results of parsing operation name, got %d from %s", 2, len(matches), w.Op.Name) | ||
} | ||
op, err := w.Service.Apps.Operations.Get(w.AppId, matches[1]).Do() | ||
if err != nil { | ||
return nil, "", err | ||
} | ||
|
||
log.Printf("[DEBUG] Got %v when asking for operation %q", op.Done, w.Op.Name) | ||
return op, strconv.FormatBool(op.Done), nil | ||
} | ||
} | ||
|
||
func (w *AppEngineOperationWaiter) Conf() *resource.StateChangeConf { | ||
return &resource.StateChangeConf{ | ||
Pending: []string{"false"}, | ||
Target: []string{"true"}, | ||
Refresh: w.RefreshFunc(), | ||
} | ||
} | ||
|
||
// AppEngineOperationError wraps appengine.Status and implements the | ||
// error interface so it can be returned. | ||
type AppEngineOperationError appengine.Status | ||
|
||
func (e AppEngineOperationError) Error() string { | ||
return e.Message | ||
} | ||
|
||
func appEngineOperationWait(client *appengine.APIService, op *appengine.Operation, appId, activity string) error { | ||
return appEngineOperationWaitTime(client, op, appId, activity, 4) | ||
} | ||
|
||
func appEngineOperationWaitTime(client *appengine.APIService, op *appengine.Operation, appId, activity string, timeoutMin int) error { | ||
w := &AppEngineOperationWaiter{ | ||
Service: client, | ||
Op: op, | ||
AppId: appId, | ||
} | ||
|
||
state := w.Conf() | ||
state.Delay = 10 * time.Second | ||
state.Timeout = time.Duration(timeoutMin) * time.Minute | ||
state.MinTimeout = 2 * time.Second | ||
opRaw, err := state.WaitForState() | ||
if err != nil { | ||
return fmt.Errorf("Error waiting for %s: %s", activity, err) | ||
} | ||
|
||
resultOp := opRaw.(*appengine.Operation) | ||
if resultOp.Error != nil { | ||
return AppEngineOperationError(*resultOp.Error) | ||
} | ||
|
||
return nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry this is such a nit to pick, but
IdRE
bugs me - can it beIdRegex
orIdRegEx
orIDReg
orIdReg
or something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be! I'll push an update for you to approve momentarily.