Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspectConfig added to jobTrigger #14401

Merged
merged 1 commit into from
Apr 21, 2023
Merged

inspectConfig added to jobTrigger #14401

merged 1 commit into from
Apr 21, 2023

Conversation

modular-magician
Copy link
Collaborator

Added inspectConfig block with all the attributes to inspectJob in jobTrigger resource and also added relevant test cases.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dlp: added `inspectConfig` field to `google_data_loss_prevention_job_trigger` resource

Derived from GoogleCloudPlatform/magic-modules#7677

@modular-magician
inspectConfig added to jobTrigger (hashicorp#7677)
f001b87 
* inspectConfig added to jobTrigger

* Test Precheck Updated

* fields added to test

* removed deprecated attributes contentOptions and detectionRules

* customInfoTypes tests added covering all attributes

* tabs removed from erb file and double space added

* removed required from mentioned attributes

* minor changes

* Additional test for Exclusion Rule added

* removing required from hotwordRegex and pattern

* Spacing changed

* immutable removed from customInfoType attributes

* required removed from proximity

* required removed from proximity and likelihoodAdjustment in rules

* Tests modified and new cases added

* added remaining 4 attr to test config

* minor changes

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit f9227e7 into hashicorp:main Apr 21, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician