Add time partitioning field to google_bigquery_table resource

[amatellanes]

Add time partitioning field to google_bigquery_table resource. This field is available on type TimePartitioning from package bigquery:

type TimePartitioning struct {
    ...

    // If empty, the table is partitioned by pseudo column '_PARTITIONTIME'; if set, the
    // table is partitioned by this field. The field must be a top-level TIMESTAMP or
    // DATE field. Its mode must be NULLABLE or REQUIRED.
    Field string
}

[danawillow]

Mind adding a test (or updating an existing one) to use the new field?

[danawillow]

shouldn't this be tp.Field?

[amatellanes]

@danawillow I have fix flattenTimePartitioning function to retrieve field. Also I have created TestAccBigQueryTable_TimePartitioningField test to check time partitioning field but I'm not really sure if I should have added this test to an existing one... perhaps TestAccBigQueryTable_Basic...

[danawillow]

Thanks! Yeah I think having it in basic would work fine. Do you mind also adding an import step to the test? We're trying to standardize on as many tests as possible having that step since it lets us check that all the fields match. It would look like this:

			{
				ResourceName:        "google_bigquery_table.test",
				ImportState:         true,
				ImportStateVerify:   true,
			},

[amatellanes]

Hi @danawillow

Changes done.

[danawillow]

Hey @amatellanes, I'm not sure if you were intending to have the test update the existing table, but by having the two steps in the same test that's what it tried to do. It sounds like from this error message that you can't update that field. If that's true, can you make it ForceNew?

$ make testacc TEST=./google TESTARGS='-run=TestAccBigQueryTable_Basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccBigQueryTable_Basic -timeout 120m
=== RUN   TestAccBigQueryTable_Basic
=== PAUSE TestAccBigQueryTable_Basic
=== CONT  TestAccBigQueryTable_Basic
--- FAIL: TestAccBigQueryTable_Basic (6.64s)
	testing.go:513: Step 2 error: Error applying: 1 error(s) occurred:

		* google_bigquery_table.test: 1 error(s) occurred:

		* google_bigquery_table.test: googleapi: Error 400: Cannot change partitioning spec for a partitioned table., invalid
FAIL
FAIL	github.com/terraform-providers/terraform-provider-google/google	6.847s
make: *** [testacc] Error 1

[amatellanes]

I've just marked the field as ForceNew. Since we cannot update partitioning field for a partitioned table, should I create a new test or modify testAccBigQueryTable to add the field Field to time_partitioning block?

[danawillow]

I would just modify testAccBigQueryTable but I don't care particularly strongly

[amatellanes]

Finally I've chosen to modify testAccBigQueryTable.

[danawillow]

$ make testacc TEST=./google TESTARGS='-run=TestAccBigQueryTable_Basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccBigQueryTable_Basic -timeout 120m
=== RUN   TestAccBigQueryTable_Basic
=== PAUSE TestAccBigQueryTable_Basic
=== CONT  TestAccBigQueryTable_Basic
--- PASS: TestAccBigQueryTable_Basic (5.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	5.753s

Thanks @amatellanes! Looks good!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!