Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dataplex Asset resource #12210

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Add Dataplex Asset resource #12210

merged 1 commit into from
Jul 29, 2022

Conversation

modular-magician
Copy link
Collaborator

part of #11648

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.
`google_dataplex_asset`

Derived from GoogleCloudPlatform/magic-modules#6310

@modular-magician
Add Dataplex Asset resource (hashicorp#6310)
2cebde2 
* Initial commit, verify asset.yaml

* Use an existing public bucket

* Add Dataplex Asset into provider.go

* Use a sample bucket instead of a hardcoded one

* Fix asset YAML to have asset field

* Fix asset YAML to have bucket field

* Try again with a hardcoded bucket

* minor syntax fix

* Using handwritten tests since GCS buckets are not in DCL

* Fix bucket name reference in Dataplex Asset

* Ignore updates to bucket after creation

* Change dataplex terraform resource name to primary for the tests

* Add override for resource_spec.name. This is an immutable field and is normalized by the API.

* upgrade dcl to 1.16

* Update test to use dataplexZone instead of zone

* Add back comment accidentally removed in merge

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit ac72df5 into hashicorp:main Jul 29, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@modular-magician