Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rolling update functionality #1114

Conversation

ishashchuk
Copy link
Contributor

Addresses 51

Supports beta functionality on rolling updates.

rolling_update_policy block is stored in state file only(as opposed to applying it to InstanceManager object), and is applied at patch call only. That allows for flexibility of modifying it, as needed. If applied to InstanceManager, it can't be modified without re-creating the InstanceManager, but it can be modified on the patch calls.

I have also chose to have two separate arguments that are in conflict with each other for "fixed" and "percent" values. I think it's a little cleaner, since we can do appropriate validations on "Int"s and not have to convert values to appropriate types a bunch of times
As an alternative, I could consolidate them to a single argument of type string, and do regex parsing to figure out whether it's a percent value(contains '%') or fixed value(number only), but I seem to like the first approach a little better. Please, let me know what you think regarding this

@ishashchuk ishashchuk closed this Feb 21, 2018
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant