Support for rolling update functionality #1114
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 51
Supports beta functionality on rolling updates.
rolling_update_policy block is stored in state file only(as opposed to applying it to InstanceManager object), and is applied at patch call only. That allows for flexibility of modifying it, as needed. If applied to InstanceManager, it can't be modified without re-creating the InstanceManager, but it can be modified on the patch calls.
I have also chose to have two separate arguments that are in conflict with each other for "fixed" and "percent" values. I think it's a little cleaner, since we can do appropriate validations on "Int"s and not have to convert values to appropriate types a bunch of times
As an alternative, I could consolidate them to a single argument of type string, and do regex parsing to figure out whether it's a percent value(contains '%') or fixed value(number only), but I seem to like the first approach a little better. Please, let me know what you think regarding this