-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set metadata_startup_script in some cases. #1081
Don't set metadata_startup_script in some cases. #1081
Conversation
Should we add a ConflictsWith to ensure people don't set both? |
Can't, unfortunately - |
Shoot - I've got a problem with updates from |
Got it. Running the tests. |
All the tests passed, merging. |
BigQuery Dataset default CMEK encryption
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
If the state contains
metadata.startup-script
, the user likely wants to keep it in there instead ofmetadata_startup_script
(which isForceNew
, wheremetadata.startup-script
is not). This isn't the standard case -metadata.startup-script
creates heterogeneous fleets unless managed very carefully, which is whymetadata_startup_script
exists - but it's supported by the API and it's a valid state, so we want it to continue working.After this PR:
metadata_startup_script
and don't setmetadata.startup-script
, you will see no change.metadata.startup-script
and don't setmetadata_startup_script
, you will stop seeing permanent diffs, becauseRead
will stop settingmetadata_startup_script
.metadata_startup_script
.If you're affected by something like #1079, this will make sure that you don't have problems going for anything created after this PR goes in, but for your existing instances you'll need to make sure that the
metadata.startup-script
has a non-empty value, probably using theterraform state
functions.