-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resourcemanager: adding "google_folders" data source #10261
Conversation
Hi @slevenick - is there anything else we need to validate/update here? Thank you! |
Hi @megan07 @slevenick is there anything else we need to do here to get this data source added in? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the test fails with:
provider_test.go:278: Step 1/1 error: Check failed: Check 1/8 error: Not found: data.google_folders.my-folder in [root]
Are you able to run this test locally?
It should pass now; I was running the wrong test locally, and got the failure you saw when I ran the right test. Sorry about that!
|
I also signed the CLA, so hopefully that check will pass now in MM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
The goal of this PR is to add a new data source to the provider,
google_folders
, to allow terraform code to enumerate a list of folders within a parent object (org or folder).The code was modified from the existing
google_projects
data source to fit the needs of querying folders from the resourcemanager api v3.