Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support version_retention_period with google_spanner_database #8994

Comments

@sho-abe
Copy link

sho-abe commented Apr 26, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

I would like to set the PITR (version_retention_period) of Spanner Database using Terraform.

The version_retention_period of Spanner Database is output-only with the REST API, and I need to use updateDdl and ALTER DATABASE to set it.
If google_spanner_database implements the logic to be set by updateDdl, it is very useful because the setting is completed only by Terraform.

New or Affected Resource(s)

  • google_spanner_database

Potential Terraform Configuration

resource "google_spanner_database" "sample" {
  instance                 = "sample"
  name                     = "sample-pitr"
  version_retention_period = "7d" 
}

References

@megan07 megan07 added the size/s label Apr 26, 2021
@megan07 megan07 added this to the Goals milestone Apr 26, 2021
@BenCoughlan15
Copy link

Would really appreciate this one.

Is it something we can contribute towards?

@BenCoughlan15
Copy link

Still no movement on this, can I add a PR for this?

@marktru
Copy link

marktru commented Mar 31, 2022

@BenCoughlan15 - Hi Ben, yes you can certainly create a PR if you are still interested!

@SarahFrench
Copy link
Member

🙋‍♀️ I'm currently working on a PR for this

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.