-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanner Database Resource should support versionRetentionPeriod and earliestVersionTime #544
Comments
Based on the other Issues/PRs I see we need to wait for terraform to support it: hashicorp/terraform-provider-google#8994 will solve this. |
Hi!
Yes, exactly. Once it's in Terraform expect a 2-3 week maximum delay for it to appear in the next version of Config Connector. |
@toumorokoshi based on: GoogleCloudPlatform/magic-modules#6141 and the other issue being closed for 30 days, should we expect this to land in config connector in the next release? Or is it already available? |
Hi! Just as an FYI I've moved teams, so may not able to help as much. I took a quick look at the docs and I don't see the field appearing yet. Likely it will be picked up a Terraform update in the next week or so. An engineer working on the product should be able to reply soon with more details. |
@knechtionscoding Likely we will update Config Connector's Terraform provider next week, so this change should be included in our release the week after that, which will be Config Connector v1.92.0. |
@knechtionscoding correction - we won't be updating our Terraform provider this week. We should be updating it two weeks from now, so this change will be included in our release 3 weeks from now. |
/fixed |
Describe the feature or resource
Spanner Database Resource should support setting the versionRetentionPeriod and earliestVersionTime to allow for PITR:
https://cloud.google.com/blog/products/databases/continuous-data-protection-here-for-spanner-with-pitr
k8s-config-connector/pkg/apis/spanner/v1beta1/spannerdatabase_types.go
Lines 44 to 62 in 531fa4f
Importance
Currently this has to be set manually via the console or the cli rather than being stored in the cnrm config for the resource. Would greatly improve the ability to provision spanner via cnrm
The text was updated successfully, but these errors were encountered: