Spanner Database Resource should support versionRetentionPeriod and earliestVersionTime

[knechtionscoding]

Describe the feature or resource
Spanner Database Resource should support setting the versionRetentionPeriod and earliestVersionTime to allow for PITR:

https://cloud.google.com/blog/products/databases/continuous-data-protection-here-for-spanner-with-pitr

k8s-config-connector/pkg/apis/spanner/v1beta1/spannerdatabase_types.go

Lines 44 to 62 in 531fa4f

	type SpannerDatabaseSpec struct {
	/* An optional list of DDL statements to run inside the newly created
	database. Statements can create tables, indexes, etc. These statements
	execute atomically with the creation of the database: if there is an
	error in any statement, the database is not created. */
	// +optional
	Ddl []string `json:"ddl,omitempty"`
	/* Immutable. Encryption configuration for the database */
	// +optional
	EncryptionConfig *DatabaseEncryptionConfig `json:"encryptionConfig,omitempty"`
	/* The instance to create the database on. */
	InstanceRef v1alpha1.ResourceRef `json:"instanceRef"`
	/* Immutable. Optional. The name of the resource. Used for creation and acquisition. When unset, the value of `metadata.name` is used as the default. */
	// +optional
	ResourceID *string `json:"resourceID,omitempty"`
	}

Importance

Currently this has to be set manually via the console or the cli rather than being stored in the cnrm config for the resource. Would greatly improve the ability to provision spanner via cnrm

[knechtionscoding]

Based on the other Issues/PRs I see we need to wait for terraform to support it: hashicorp/terraform-provider-google#8994 will solve this.

[toumorokoshi]

Hi!

Based on the other Issues/PRs I see we need to wait for terraform to support it: hashicorp/terraform-provider-google#8994 will solve this.

Yes, exactly. Once it's in Terraform expect a 2-3 week maximum delay for it to appear in the next version of Config Connector.

[knechtionscoding]

@toumorokoshi based on: GoogleCloudPlatform/magic-modules#6141 and the other issue being closed for 30 days, should we expect this to land in config connector in the next release? Or is it already available?

[toumorokoshi]

Hi! Just as an FYI I've moved teams, so may not able to help as much.

I took a quick look at the docs and I don't see the field appearing yet. Likely it will be picked up a Terraform update in the next week or so.

An engineer working on the product should be able to reply soon with more details.

[mbzomowski]

@knechtionscoding Likely we will update Config Connector's Terraform provider next week, so this change should be included in our release the week after that, which will be Config Connector v1.92.0.

[mbzomowski]

@knechtionscoding correction - we won't be updating our Terraform provider this week. We should be updating it two weeks from now, so this change will be included in our release 3 weeks from now.

[cheftako]

/fixed
https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/v1.113.0/config/crds/resources/apiextensions.k8s.io_v1_customresourcedefinition_spannerdatabases.spanner.cnrm.cloud.google.com.yaml#L146 shows the version retention period. I do not believe earliestVersionTime was added to TF>