Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access[].routine for Bigquery dataset #7530

Closed
edwardmedia opened this issue Oct 14, 2020 · 4 comments
Closed

Add access[].routine for Bigquery dataset #7530

edwardmedia opened this issue Oct 14, 2020 · 4 comments

Comments

@edwardmedia
Copy link
Contributor

edwardmedia commented Oct 14, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

With the addition of Bigquery Routine to Dataset, the access[].routine should be added accordingly in the Dataset

New or Affected Resource(s)

  • google_bigquery_dataset

Potential Terraform Configuration

b/359365053

@ghost ghost added the enhancement label Oct 14, 2020
@edwardmedia edwardmedia changed the title Add RoutineReference for Bigquery dataset Add access[].routine for Bigquery dataset Oct 14, 2020
@rileykarson
Copy link
Collaborator

note: we should consider the impact on bigquery_iam and bigquery_dataset_access resources as well

@rileykarson rileykarson added this to the Goals milestone Oct 19, 2020
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Mar 27, 2023
@github-actions github-actions bot added service/bigquery forward/review In review; remove label to forward labels Aug 17, 2023
@ggtisc ggtisc removed the forward/review In review; remove label to forward label Aug 12, 2024
@wj-chen
Copy link

wj-chen commented Aug 13, 2024

This was added in GoogleCloudPlatform/magic-modules#6680. @ScottSuarez , could you close this issue?

@ScottSuarez
Copy link
Collaborator

ack, done . Thanks for checking!!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants