Make node auto-repair default to true

[danawillow]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

From MSA email:

we will be enabling Google Kubernetes Engine (GKE) node auto-repair by default in the GKE API for newly created clusters and node pools beginning on May 28, 2020.

Right now the schema around there looks like this:

	"management": {
		Type:     schema.TypeList,
		Optional: true,
		Computed: true,
		MaxItems: 1,
		Elem: &schema.Resource{
			Schema: map[string]*schema.Schema{
				"auto_repair": {
					Type:     schema.TypeBool,
					Optional: true,
					Default:  false,
				},

				"auto_upgrade": {
					Type:     schema.TypeBool,
					Optional: true,
					Default:  false,
				},
			},
		},
	},

So this basically just affects users who set auto_upgrade only and let auto_repair be the default. We should default auto_repair to true in order to match the server-side default.

Users with no management block will just get a server-side default.

New or Affected Resource(s)

• google_container_node_pool

b/299442391

[c2thorn]

closed with GoogleCloudPlatform/magic-modules#8967

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.