-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Composer connection resource #4418
Comments
Hi @danawillow when will this implemented in terraform? |
We don't have a timeline for this feature yet. We're happy to accept PRs (see https://github.com/terraform-providers/terraform-provider-google/blob/master/.github/CONTRIBUTING.md; we generally add new resources viaMagic Modules instead of in TF directly). Otherwise, if you have an account manager, customer engineer, or other contact at Google or HashiCorp, you can ask them to reach out to our team to prioritize it higher. |
Helo @danawillow, any chance for making this happen in 2020? |
Same comment as before applies! |
@danawillow I was wondering if there's specific API in golang equivalent with run command. From what I've seen in the API. Note that we're using this for the Terraform Provider there's several utility for |
I don't see anything at the link you posted or at https://cloud.google.com/composer/docs/reference/rest. If you run gcloud with |
Co-authored-by: upodroid <[email protected]> Signed-off-by: Modular Magician <[email protected]>
Co-authored-by: upodroid <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: upodroid <[email protected]>
If necessary this feature |
Do not use terraform for everything ! airflow connections store them in JSON files that you load with the airflow cli or airflow REST API ( since airflow v2) Do that in your CD pipelines the same way you publish your airflow DAGS and airflow plugins with your CD and not terraform |
FYI I forked the airflow tf provider and added support for this and more: |
We use Terraform to publish DAGs etc. |
Moving into Goals to mark that we'd like to support this, if possible. We're not sure that this is possible through the Composer API today (although gcloud seems to be able to, as folks suggest). We'll reach out to Cloud Composer engineers to figure out whether we're just missing something. If this is not possible through their API, we'd want to recommend using other providers, most likely. |
That would require exposing native Airflow configuration directly in Terraform - something we don't do at the moment and do not have plans in the imminent future. |
Community Note
Description
In addition to being able to create Cloud Composer Environments through Terraform, it would be nice if we could set up connections, and perhaps some other internal config as well.
New or Affected Resource(s)
google_composer_environment_connection
Potential Terraform Configuration
This can be implemented via the
gcloud
utility e.g.gcloud composer environments run my-environment --location us-central1 connections -- --add
, but there doesn't appear to be an equivalent REST API command. Still I'm sure there must be a way to do it. Just do whatevergcloud
does.b/299443256
The text was updated successfully, but these errors were encountered: