Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: r/google_compute_router_nat example does not include required subnetwork.source_ip_ranges_to_nat field #3516

Closed
kkleidal opened this issue Apr 30, 2019 · 1 comment · Fixed by #3517
Labels

Comments

@kkleidal
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
  • If an issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to "hashibot", a community member has claimed the issue already.

Terraform Version

master @b21921fad297a983937286d63b9b0dab08ba3b1a

Affected Resource(s)

  • compute_router_nat

Description

This is a documentation error with the following file: https://github.com/kkleidal/terraform-provider-google/blob/b21921fad297a983937286d63b9b0dab08ba3b1a/website/docs/r/compute_router_nat.html.markdown.

The second example contains the subnetwork block:

subnetwork {
  name = "${google_compute_subnetwork.subnetwork.self_link}"
}

which doesn't contain the required argument source_ip_ranges_to_nat.

@ghost ghost added the bug label Apr 30, 2019
kkleidal added a commit to kkleidal/terraform-provider-google that referenced this issue Apr 30, 2019
@rileykarson rileykarson self-assigned this Apr 30, 2019
@rileykarson rileykarson assigned hashibot and unassigned rileykarson Apr 30, 2019
kkleidal added a commit to kkleidal/terraform-provider-google that referenced this issue Apr 30, 2019
@ghost
Copy link

ghost commented Jun 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants