-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore database with delete protection enabled should fail on destroy #16325
Closed
IchordeDionysos opened this issue
Oct 20, 2023
· 1 comment
· Fixed by GoogleCloudPlatform/magic-modules#9450, hashicorp/terraform-provider-google-beta#6664, #16576 or GoogleCloudPlatform/terraform-google-conversion#1720
Closed
Firestore database with delete protection enabled should fail on destroy #16325
IchordeDionysos opened this issue
Oct 20, 2023
· 1 comment
· Fixed by GoogleCloudPlatform/magic-modules#9450, hashicorp/terraform-provider-google-beta#6664, #16576 or GoogleCloudPlatform/terraform-google-conversion#1720
Comments
github-actions
bot
added
forward/review
In review; remove label to forward
service/firestore-controlplane
labels
Oct 20, 2023
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 9, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * Either delete protection or deletion policy being set prevents destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 10, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * Either delete protection or deletion policy being set prevents destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 10, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * Either delete protection or deletion policy being set prevents destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 10, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * Either delete protection or deletion policy being set prevents destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 10, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * Either delete protection or deletion policy being set prevents destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 10, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * Either delete protection or deletion policy being set prevents destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 10, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * Either delete protection or deletion policy being set prevents destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 10, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * Either delete protection or deletion policy being set prevents destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 10, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * Either delete protection or deletion policy being set prevents destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 10, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 14, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 14, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
rwhogg
added a commit
to rwhogg/magic-modules
that referenced
this issue
Nov 21, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
slevenick
pushed a commit
to GoogleCloudPlatform/magic-modules
that referenced
this issue
Nov 21, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
modular-magician
added a commit
to modular-magician/terraform-provider-google-beta
that referenced
this issue
Nov 21, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325 [upstream:4829cc4a4f604db5d6e1d09a7c85df6250ebc19a] Signed-off-by: Modular Magician <[email protected]>
This was referenced Nov 21, 2023
modular-magician
added a commit
to modular-magician/terraform-provider-google
that referenced
this issue
Nov 21, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp#16488 Fixes hashicorp#16404 Fixes hashicorp#16325 [upstream:4829cc4a4f604db5d6e1d09a7c85df6250ebc19a] Signed-off-by: Modular Magician <[email protected]>
modular-magician
added a commit
to hashicorp/terraform-provider-google-beta
that referenced
this issue
Nov 21, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325 [upstream:4829cc4a4f604db5d6e1d09a7c85df6250ebc19a] Signed-off-by: Modular Magician <[email protected]>
modular-magician
added a commit
that referenced
this issue
Nov 21, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes #16488 Fixes #16404 Fixes #16325 [upstream:4829cc4a4f604db5d6e1d09a7c85df6250ebc19a] Signed-off-by: Modular Magician <[email protected]>
modular-magician
added a commit
to modular-magician/terraform-google-conversion
that referenced
this issue
Nov 21, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325 [upstream:4829cc4a4f604db5d6e1d09a7c85df6250ebc19a] Signed-off-by: Modular Magician <[email protected]>
modular-magician
added a commit
to GoogleCloudPlatform/terraform-google-conversion
that referenced
this issue
Nov 21, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325 [upstream:4829cc4a4f604db5d6e1d09a7c85df6250ebc19a] Signed-off-by: Modular Magician <[email protected]>
jialei-chen
pushed a commit
to jialei-chen/magic-modules
that referenced
this issue
Nov 29, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
trodge
pushed a commit
to trodge/magic-modules
that referenced
this issue
Dec 8, 2023
Due to backwards compatibility concerns, the default behavior remains to abandon the database upon destroy rather than to actually delete it. To actually delete the database, you must set deletion_policy to DELETE, and apply if necessary, before running `terraform destroy`. This also cleans up some related deletion-related docs and bugs: * Updates the delete protection docs * delete_protection_state being enabled with deletion_policy = DELETE fails the destroy Fixes hashicorp/terraform-provider-google#16488 Fixes hashicorp/terraform-provider-google#16404 Fixes hashicorp/terraform-provider-google#16325
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Community Note
modular-magician
user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned tohashibot
, a community member has claimed the issue already.Terraform Version
Affected Resource(s)
Terraform Configuration Files
Debug Output
Truncated output
Expected Behavior
Fail the destruction of the Firestore database.
Potentially even planning to destroy a Firestore database that has delete protection enabled.
The information should be there during plan time I think 🤔
Actual Behavior
Terraform claims to have successfully deleted the Firestore database.
Steps to Reproduce
terraform apply
terraform destroy
Important Factoids
References
b/306863791
The text was updated successfully, but these errors were encountered: