Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enable pub sub subscription push unwrapping without enabling metadata writes #15555

Comments

@brett-patterson-ent
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to the modular-magician user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to hashibot, a community member has claimed the issue already.

Terraform Version

Terraform v1.5.2
on darwin_amd64
+ provider registry.terraform.io/hashicorp/google v4.78.0

Affected Resource(s)

  • google_pubsub_subscription

Terraform Configuration Files

resource "google_pubsub_topic" "test" {
  name = "test-topic"
}

resource "google_pubsub_subscription" "test_push" {
  name  = "test-push"
  topic = google_pubsub_topic.test.name


  push_config {
    push_endpoint = "https://google.com"

    no_wrapper {
      write_metadata = false
    }
  }
}

Debug Output

https://gist.github.com/brett-patterson-ent/783e10a9545b6577b1801c5880a7ecda

Panic Output

Expected Behavior

The pub sub subscription should be created with "Push payload unwrapping" enabled but "Push payload unwrapping write message metadata" disabled

Actual Behavior

Both "Push payload unwrapping" and "Push payload unwrapping write message metadata" are disabled

Steps to Reproduce

  1. terraform apply

Important Factoids

You can see in the debug log that the PUT request to /v1/projects/<redacted>/subscriptions/test-push has the "pushConfig.noWrapper" property omitted completely, but it should be sent as {} or {"writeMetadata":false}

References

@github-actions github-actions bot added forward/review In review; remove label to forward service/pubsub labels Aug 18, 2023
@edwardmedia
Copy link
Contributor

b/296582112

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.