Make google_compute_router_nat's source_ip_ranges_to_nat Required (#2749

)  /cc @rileykarson
hashicorp · Dec 27, 2018 · a3caf90 · a3caf90
1 parent 91a513a
commit a3caf90
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/google/resource_compute_router_nat.go b/google/resource_compute_router_nat.go
@@ -22,9 +22,14 @@ var (
 				Required: true,
 				ForceNew: true,
 			},
+
+			// this field is optional with a default in the API, but we
+			// don't have the ability to support complex defaults inside
+			// nested fields
 			"source_ip_ranges_to_nat": {
 				Type:     schema.TypeSet,
-				Optional: true,
+				Required: true,
+				MinItems: 1,
 				ForceNew: true,
 				Elem:     &schema.Schema{Type: schema.TypeString},
 			},

diff --git a/website/docs/r/compute_router_nat.html.markdown b/website/docs/r/compute_router_nat.html.markdown
@@ -149,7 +149,7 @@ The `subnetwork` block supports:
 
 * `name` - (Required) The `self_link` of the subnetwork to NAT.
 
-* `source_ip_ranges_to_nat` - (Optional) List of options for which source IPs in the subnetwork
+* `source_ip_ranges_to_nat` - (Required) List of options for which source IPs in the subnetwork
     should have NAT enabled. Supported values include: `ALL_IP_RANGES`,
     `LIST_OF_SECONDARY_IP_RANGES`, `PRIMARY_IP_RANGE`