Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate lifecyclePolicy.updateOnRepair to GA #5963

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#15244

Add support for forcing update on repair in instance lifecycle policy in compute_instance_group_manager and compute_region_instance_group_manager resources (GA).

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • While running the tests one of them fails (TestAccInstanceGroupManager_waitForStatus), but it does not use the new field and it simply times out.
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added field `instance_lifecycle_policy` to `google_compute_instance_group_manager` and `google_compute_region_instance_group_manager` (ga)

Derived from GoogleCloudPlatform/magic-modules#8412

* migrate lifecyclePolicy.updateOnRepair to GA

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit ffd4d8f into hashicorp:main Jul 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

promote (Regional)InstanceGroupManager.lifecyclePolicy.updateOnRepair to GA
1 participant